Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-97] Route Workspaces team alerts to Core Services slack channel #3085

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

marctalbott
Copy link
Contributor

@marctalbott marctalbott commented Oct 17, 2024

Ticket: CORE-97

  • move #dsp-workspaces-test-alerts to #dsp-core-services-alerts

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

Sorry, something went wrong.

@marctalbott marctalbott requested review from a team, dvoet and trholdridge and removed request for a team October 17, 2024 20:59
STAGING_CHANNELS: 'C03F21QEWV7,C53JYBV9A' # C53JYBV9A channel is for #dsde-qa
DEV_CHANNELS: 'C03F21QEWV7' #dsp-workspaces-test-alerts
STAGING_CHANNELS: 'C07Q8H7F8LV,C53JYBV9A' # C53JYBV9A channel is for #dsde-qa
DEV_CHANNELS: 'C07Q8H7F8LV' #dsp-core-services-alerts
Copy link
Contributor

@trholdridge trholdridge Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the alerts channel for all test notifications or only failing ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general approach was to leave the alerting logic alone and just port it over to the new channel. I'm typically in favor of only alerting on failures, but this test doesn't run all that often and if we do decide the channel is too noisy then the success alerts here might be a good candidate to remove.

@marctalbott marctalbott merged commit 20a213c into develop Oct 18, 2024
30 checks passed
@marctalbott marctalbott deleted the mtalbott-core-test-notifications branch October 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants