CORE-188: batch upsert tracing #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Dec 5, 2024
| for { | ||
| _ <- traceDBIOWithParent("insertIntoScratchFunction", span)(_ => insertIntoScratchFunction()) | ||
| numUpdates <- traceDBIOWithParent("updateInMasterAction", span)(_ => updateInMasterAction()) | ||
| } yield numUpdates |
There was a problem hiding this comment.
the change from andThen to for ... yield ensures the second "updateInMasterAction" trace does not start eagerly
davidangb
commented
Dec 5, 2024
| } | ||
| } | ||
|
|
||
| traceDBIOWithParent("saveAction", localContext)(_ => saveAction) | ||
| saveAction |
There was a problem hiding this comment.
moving the trace wrapper up ensures it does not start eagerly
davidangb
requested review from
marctalbott and
trholdridge
and removed request for
a team
marctalbott
approved these changes
Dec 6, 2024
trholdridge
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CORE-188
The batchUpsert API is used by TSV uploads, among others.
In this PR:
Before this PR
getActiveEntitiesandsaveActionsubspans appear to start at the same time, which is incorrectLocalEntityProvider.batchUpdateEntitiesImplsubspanAfter this PR:
LocalEntityProvider.batchUpdateEntitiesImplsubspangetActiveEntitiesandsaveActionis more accuratePR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.