Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-216: validate per-workflow cost cap values #3148

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 6, 2024

Ticket: https://broadworkbench.atlassian.net/browse/CORE-216

Add backend validation of the per-workflow cost cap. The UI still allows you to enter invalid cost-cap values (we'll need a separate PR for UI validation). However, as of this PR, we'll throw an error immediately upon submission, instead of allowing the submission to launch and then fail.

Screenshots from my BEE:
Screenshot 09-12-2024 at 10 22
Screenshot 09-12-2024 at 10 21


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@davidangb davidangb marked this pull request as ready for review December 9, 2024 15:25
@davidangb davidangb requested a review from a team as a code owner December 9, 2024 15:25
@davidangb davidangb requested review from dvoet and samanehsan and removed request for a team December 9, 2024 15:25
@davidangb davidangb merged commit cefaea5 into develop Dec 9, 2024
29 checks passed
@davidangb davidangb deleted the da_CORE-216_costCapValidation branch December 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants