Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-227] Only insert into AUDIT_WORKFLOW_STATUS when the workflow status changes #3155

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[CORE-227] Only insert into AUDIT_WORKFLOW_STATUS when the workflow status changes #3155

merged 1 commit into from
Dec 19, 2024

Conversation

marctalbott
Copy link
Contributor

@marctalbott marctalbott commented Dec 19, 2024 •
edited by jira bot
Loading

Ticket: CORE-227

  • Change trigger on AUDIT_WORKFLOW_STATUS table to only insert new records when a workflow status changes as opposed to on every update to the WORKFLOW table

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and perform the corresponding dependency updates as specified in the README:
    • in the automation subdirectory
    • in workbench-libs
    • in firecloud-orchestration
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@marctalbott marctalbott requested a review from a team as a code owner December 19, 2024 21:44
@marctalbott marctalbott requested review from kevinpalis and davidangb and removed request for a team December 19, 2024 21:44
kevinpalis
kevinpalis approved these changes Dec 19, 2024
View reviewed changes
Copy link

@kevinpalis kevinpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidangb
davidangb approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right to me! I did not test; assuming you did.

@marctalbott marctalbott merged commit 8281027 into develop Dec 19, 2024
30 checks passed
@marctalbott marctalbott deleted the mtalbott-audit-workflow-status-frequency branch December 19, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidangb davidangb davidangb approved these changes

@kevinpalis kevinpalis kevinpalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marctalbott @kevinpalis @davidangb