Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance of browscap 3.x #101

Closed
asgrim opened this issue Sep 6, 2015 · 1 comment
Closed

Increase performance of browscap 3.x #101

asgrim opened this issue Sep 6, 2015 · 1 comment
Assignees
Milestone

Comments

@asgrim
Copy link
Member

asgrim commented Sep 6, 2015

As per conversation with @jaydiablo here, I'd like to review the performance of the 3.x series.

Although we have significantly reduced the memory usage in 3.x, it now takes much longer to process.

@jaydiablo has pinpointed a potential big win:

This was the biggest win for me when I was trying to optimize crossjoin: https://github.com/crossjoin/Browscap/commit/2ee9663bd4b971c658d87f33fe780858580f7bd4 (the digit replacement in that commit is a bit overzealous, and causes tests to fail, which was fixed later https://github.com/crossjoin/Browscap/commit/afd9f8eaec3fe506ed864a93a536e2370b570922)

Investigate this and see if we can optimise similarly.

@asgrim asgrim added this to the 3.0.0 milestone Sep 6, 2015
@asgrim asgrim mentioned this issue Sep 17, 2015
@mimmi20
Copy link
Member

mimmi20 commented Nov 16, 2015

The changes from crossjoin/Browscap@2ee9663 were reimplemented in the optimize branch and merged at the 26.09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants