Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Optimize #108

Merged
merged 30 commits into from
Sep 26, 2015
Merged

[3.x] Optimize #108

merged 30 commits into from
Sep 26, 2015

Conversation

mimmi20
Copy link
Member

@mimmi20 mimmi20 commented Sep 16, 2015

This PR indents to use changes from crossjoin/Browscap here too, to make the detection faster.

This PR is related to #101.

@asgrim asgrim added this to the 3.0.0 milestone Sep 17, 2015
@asgrim asgrim self-assigned this Sep 17, 2015
@asgrim
Copy link
Member

asgrim commented Sep 17, 2015

Is this related to #101 ?

@@ -0,0 +1,96 @@
<?php
/**
* Copyright (c) 1998-2014 Browser Capabilities Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix date please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please only fix date on new code, I will clean up date on existing files separately)

@@ -0,0 +1,286 @@
<?php
/**
* Copyright (c) 1998-2014 Browser Capabilities Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix date plz

@asgrim
Copy link
Member

asgrim commented Sep 17, 2015

@mimmi20 Scrutinizr timed out also - there's a way of increasing the timeout isn't there? Can't remember what it was though

@mimmi20
Copy link
Member Author

mimmi20 commented Sep 18, 2015

I have to fix the unit tests

@mimmi20 mimmi20 closed this Sep 18, 2015
@mimmi20 mimmi20 reopened this Sep 20, 2015
mimmi20 added a commit that referenced this pull request Sep 26, 2015
@mimmi20 mimmi20 merged commit cc4b898 into browscap:master Sep 26, 2015
@mimmi20 mimmi20 deleted the optimize branch September 26, 2015 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants