Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accounts producer #14

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Feature/accounts producer #14

merged 6 commits into from
Feb 12, 2024

Conversation

pashinov
Copy link
Member

@pashinov pashinov commented Feb 9, 2024

No description provided.

@pashinov pashinov requested a review from 0xdeafbeef February 9, 2024 16:15
@pashinov pashinov force-pushed the feature/accounts_producer branch from e072931 to e1f50ec Compare February 9, 2024 16:26
server/src/ws.rs Outdated
let mut clients = self.clients.lock().await;
for (_, client) in clients.iter_mut() {
let message = Message::Binary(message.clone());
client.send(message).await?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if client stuck?

server/src/ws.rs Outdated
}

async fn handle_socket(client_id: uuid::Uuid, state: Arc<Server>, socket: WebSocket) {
let (tx, rx) = mpsc::unbounded_channel();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use channel(100) with send_timeout instead?

@0xdeafbeef 0xdeafbeef merged commit fb26aa7 into master Feb 12, 2024
4 checks passed
@0xdeafbeef 0xdeafbeef deleted the feature/accounts_producer branch February 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants