Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(collator): improve int queue performance #572

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

drmick
Copy link
Member

@drmick drmick commented Jan 27, 2025

Reducing iterator init time

master test

current branch same test

@drmick drmick requested a review from Rexagon January 27, 2025 17:11
@drmick drmick force-pushed the feature/finish-prev-externals-metrics-iter branch from ccd0d90 to 7b9dbdf Compare January 27, 2025 17:16
@drmick drmick requested a review from 0xdeafbeef January 27, 2025 17:19
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 85.08287% with 27 lines in your changes missing coverage. Please review.

Project coverage is 43.01%. Comparing base (b3e73e0) to head (4346912).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
collator/src/collator/do_collate/finalize.rs 0.00% 9 Missing ⚠️
block-util/src/queue/proto.rs 89.61% 7 Missing and 1 partial ⚠️
storage/src/store/internal_queue/mod.rs 75.75% 8 Missing ⚠️
...ollator/src/internal_queue/state/commited_state.rs 88.88% 0 Missing and 1 partial ⚠️
...ator/src/internal_queue/state/uncommitted_state.rs 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   42.95%   43.01%   +0.06%     
==========================================
  Files         277      277              
  Lines       51410    51552     +142     
  Branches    51410    51552     +142     
==========================================
+ Hits        22082    22174      +92     
- Misses      28171    28216      +45     
- Partials     1157     1162       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmick drmick force-pushed the feature/finish-prev-externals-metrics-iter branch 2 times, most recently from 631802c to 33eec3e Compare January 28, 2025 09:54
@drmick drmick changed the title Feature/finish prev externals metrics iter feature(collator): improve int queue performance Jan 28, 2025
@drmick drmick marked this pull request as ready for review January 28, 2025 09:59
@drmick drmick requested a review from SmaGMan January 28, 2025 09:59
@drmick drmick force-pushed the feature/finish-prev-externals-metrics-iter branch from 33eec3e to 6793a43 Compare January 28, 2025 12:56
@drmick drmick force-pushed the feature/finish-prev-externals-metrics-iter branch 5 times, most recently from 4346912 to 6793a43 Compare January 28, 2025 20:36
@SmaGMan SmaGMan added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit 2d19642 Jan 29, 2025
20 checks passed
@SmaGMan SmaGMan deleted the feature/finish-prev-externals-metrics-iter branch January 29, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants