Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving block to archive #573

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix moving block to archive #573

merged 1 commit into from
Jan 29, 2025

Conversation

pashinov
Copy link
Member

No description provided.

@pashinov pashinov requested a review from Rexagon January 27, 2025 17:26
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.06%. Comparing base (2d19642) to head (cf2e1ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   43.03%   43.06%   +0.03%     
==========================================
  Files         277      277              
  Lines       51549    51549              
  Branches    51549    51549              
==========================================
+ Hits        22182    22200      +18     
+ Misses      28211    28190      -21     
- Partials     1156     1159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rexagon Rexagon added this pull request to the merge queue Jan 27, 2025
@Rexagon Rexagon removed this pull request from the merge queue due to a manual request Jan 27, 2025
@Rexagon
Copy link
Member

Rexagon commented Jan 27, 2025

Don't merge yet, we need to check what happens if move_into_archive is called twice

@Rexagon Rexagon self-requested a review January 27, 2025 18:44
@Rexagon Rexagon force-pushed the fix/move-to-archive branch from da0c324 to b01e041 Compare January 29, 2025 15:54
@Rexagon Rexagon force-pushed the fix/move-to-archive branch from b01e041 to cf2e1ac Compare January 29, 2025 15:56
@Rexagon Rexagon added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit 1d37c75 Jan 29, 2025
11 checks passed
@Rexagon Rexagon deleted the fix/move-to-archive branch January 29, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants