v114.6

Fixed accuracy PPU rendering issue affecting Secret of Mana
bsnes-emu · Feb 26, 2020 · 5296176 · 5296176
1 parent 64d20a0
commit 5296176
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -68,7 +68,6 @@ Links
 
   - [Official website](https://byuu.org/bsnes)
   - [Official git repository](https://github.com/byuu/bsnes)
-  - [Developer resources](https://byuu.net)
   - [Donations](https://patreon.com/byuu)
 
 Release Builds

diff --git a/bsnes/emulator/emulator.hpp b/bsnes/emulator/emulator.hpp
@@ -29,7 +29,7 @@ using namespace nall;
 
 namespace Emulator {
   static const string Name      = "bsnes";
-  static const string Version   = "114.5";
+  static const string Version   = "114.6";
   static const string Copyright = "byuu";
   static const string License   = "GPLv3";
   static const string Website   = "https://byuu.org";

diff --git a/bsnes/sfc/ppu-fast/object.cpp b/bsnes/sfc/ppu-fast/object.cpp
@@ -142,7 +142,7 @@ auto PPU::readObject(uint10 address) -> uint8 {
     uint n = address >> 2;  //object#
     address &= 3;
     if(address == 0) return objects[n].x;
-    if(address == 1) return objects[n].y - 1;
+    if(address == 1) return objects[n].y - 1;  //-1 => rendering happens one scanline late
     if(address == 2) return objects[n].character;
     return (
       objects[n].nameselect << 0

diff --git a/bsnes/sfc/ppu/background.cpp b/bsnes/sfc/ppu/background.cpp
@@ -14,7 +14,7 @@ auto PPU::Background::scanline() -> void {
   mosaic.hoffset = 0;
 
   renderingIndex = 0;
-  pixelCounter = io.hoffset & 7;
+  pixelCounter = (io.hoffset & 7) << hires();
 
   opt.hoffset = 0;
   opt.voffset = 0;