Skip to content

Commit

Permalink
Correct syntax error
Browse files Browse the repository at this point in the history
  • Loading branch information
@btwael
btwael committed Jan 15, 2014
1 parent 717a573 commit 7e929da
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tests/heredocStringNotationSimple.mammouth
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
{{
echo `
pass
`
echo `pass`
}}

4 comments on commit 7e929da

@CezaryDanielNowak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests wasn't passing purposely, when in my opinion it should be fixed: HEREDOC is made for multi-line strings and compiler should accept that :)

@btwael
Copy link
Owner Author

@btwael btwael commented on 7e929da Jan 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that work for multi line, but remember:

`past`

is compiled to:

<<<EOD
past
EOD;

and

`
past
`

is compiled to:

<<<EOD

past

EOD;

@CezaryDanielNowak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is EOD ending indentation: it should not have ANY characters before "EOD"

@btwael
Copy link
Owner Author

@btwael btwael commented on 7e929da Jan 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remark that 'EOD' and 'EOT' php syntaxes are different than syntaxes of mammouth

Please sign in to comment.