-
Notifications
You must be signed in to change notification settings - Fork 209
Upgrade node-expat to ensure compatibility with node 10 #166
Conversation
I will cut a new release tomorrow. Thanks! |
@c4milo Would be great to have 0.11.3 ;) |
Hey! Would it be new version with upgraded node support soon? |
I will merge this PR and #159 once Travis passes. It looks like we have some memory leaks, most likely in dependencies. |
@c4milo by memory leaks you refer to this error message: "The following leaks were detected:SharedArrayBuffer, Atomics, WebAssembly" ? Those are not real memory leaks, but false positive due to differences between nodejs version used for tests, and the nodejs version handled by the version of lab (see hapijs/lab#818). I think the purpose of #159 is precisely to fix that. |
Why does it keep showing up in #159 Travis ouptput if it is fixing it? |
#159 fixes lab false positive on node 8 and 9. But we have to upgrade to at least [email protected] in order to fix the remaining error message (hapijs/lab#837). |
Hello @c4milo , |
Done. Thanks @Clement134! |
Which upgrades node-expat to 2.3.17 buglabs/node-xml2json#166
Versions of node-expat oldest than 2.3.17 are not compatible with node 10: xmppo/node-expat#190
@c4milo is it possible to merge this pull request and create a new release with all the pending fixes since the latest version ?