Skip to content
This repository has been archived by the owner on Jan 7, 2021. It is now read-only.

Upgrade node-expat to ensure compatibility with node 10 #166

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

Clement134
Copy link
Contributor

Versions of node-expat oldest than 2.3.17 are not compatible with node 10: xmppo/node-expat#190

@c4milo is it possible to merge this pull request and create a new release with all the pending fixes since the latest version ?

@c4milo
Copy link
Contributor

c4milo commented Aug 11, 2018

I will cut a new release tomorrow. Thanks!

@3z3qu13l
Copy link

@c4milo Would be great to have 0.11.3 ;)

@maximnara
Copy link

Hey! Would it be new version with upgraded node support soon?

@c4milo
Copy link
Contributor

c4milo commented Sep 13, 2018

I will merge this PR and #159 once Travis passes. It looks like we have some memory leaks, most likely in dependencies.

@Clement134
Copy link
Contributor Author

Clement134 commented Sep 15, 2018

@c4milo by memory leaks you refer to this error message: "The following leaks were detected:SharedArrayBuffer, Atomics, WebAssembly" ?

Those are not real memory leaks, but false positive due to differences between nodejs version used for tests, and the nodejs version handled by the version of lab (see hapijs/lab#818). I think the purpose of #159 is precisely to fix that.

@c4milo
Copy link
Contributor

c4milo commented Sep 15, 2018

Why does it keep showing up in #159 Travis ouptput if it is fixing it?

@Clement134
Copy link
Contributor Author

Clement134 commented Sep 15, 2018

#159 fixes lab false positive on node 8 and 9. But we have to upgrade to at least [email protected] in order to fix the remaining error message (hapijs/lab#837).

@3z3qu13l
Copy link

3z3qu13l commented Sep 25, 2018

Hello @c4milo ,
Can we merge this PR since the memory leaks is in a dev dependency and not in the code itself ?

@Clement134
Copy link
Contributor Author

I will merge this PR and #159 once Travis passes. It looks like we have some memory leaks, most likely in dependencies.

I have upgraded lab to the latest version, now all the tests on Travis are green.
@c4milo could you merge this PR ?

@c4milo c4milo merged commit 27e69ca into buglabs:master Nov 15, 2018
@c4milo
Copy link
Contributor

c4milo commented Nov 15, 2018

Done. Thanks @Clement134!

@Clement134 Clement134 deleted the upgrade-node-expat branch November 16, 2018 06:15
AlecRust added a commit to featurist/fake-sso-idp that referenced this pull request Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants