Skip to content

Commit

Permalink
Try to fix pack acceptance, continued
Browse files Browse the repository at this point in the history
Use a released version of pack when running pack acceptance (avoids v0.28.0-rc1).

In lifecycle CI, pack acceptance tests are failing on Windows when the pack version is v0.28.0-rc1.
The previous commit, which attempted to make lifecycle CI match pack CI by using go 1.17,
  did not fix the issue.
It was manually confirmed on a Windows dev worker that pack acceptance passes
  with the same pack version and the same lifecycle version that are failing in CI.
Therefore, the failling tests do not appear to relate to the lifecycle,
  and are instead likely due to other unknown differences in the CI environments that should be determined later.

Signed-off-by: Natalie Arellano <[email protected]>
  • Loading branch information
natalieparellano committed Nov 28, 2022
1 parent 91b7360 commit 8bda540
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ jobs:
- name: Run pack acceptance
run: |
cd pack
git checkout $(git describe --abbrev=0 --tags) # check out the latest tag
git checkout $(git describe --abbrev=0 --tags --exclude *-rc*) # check out the latest tag
LIFECYCLE_PATH="../lifecycle-v${{ env.LIFECYCLE_VERSION }}+linux.x86-64.tgz" \
LIFECYCLE_IMAGE="buildpacksio/lifecycle:${{ env.LIFECYCLE_IMAGE_TAG }}" \
make acceptance
Expand All @@ -280,7 +280,7 @@ jobs:
- name: Set up go
uses: actions/setup-go@v3
with:
go-version: '1.17'
go-version: '1.18'
- name: Add runner IP to daemon insecure-registries and firewall
shell: powershell
run: |
Expand Down Expand Up @@ -328,7 +328,7 @@ jobs:
- name: Run pack acceptance
run: |
cd pack
git checkout $(git describe --abbrev=0 --tags) # check out the latest tag
git checkout $(git describe --abbrev=0 --tags --exclude *-rc*) # check out the latest tag
$env:LIFECYCLE_PATH="..\lifecycle-v${{ env.LIFECYCLE_VERSION }}+windows.x86-64.tgz"
$env:LIFECYCLE_IMAGE="buildpacksio/lifecycle:${{ env.LIFECYCLE_IMAGE_TAG }}"
make acceptance
Expand Down

0 comments on commit 8bda540

Please sign in to comment.