-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Neo4j GIE #34
Conversation
@@ -106,6 +106,7 @@ def launch_proxy_command(self, config): | |||
"--sessions", config.proxy_session_map, | |||
"--ip", config.dynamic_proxy_bind_ip, | |||
"--port", str(config.dynamic_proxy_bind_port), | |||
"--cookie", "galaxysession", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed? That should be default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have been whilst debugging the issues with proxy_ipc. Having seen and noting that it's not present when galaxy launched the proxy.
For this code to work with the nginx proxy it needs this in the nginx.conf:
If this PR is being merged, we need to add this info the GIE docs. |
A bit of testing suggests that (1) is causing an issue. To reproduce the problem:
In other words, this IE doesn't play nicely with other IEs on the same server. |
As discussed this is a general IE issue at the moment, at least with the IE proxy, afaik. |
The Neo4j IE described in this issue.
Thanks to @bgruening and @erasche.