Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Neo4j GIE #34

Closed
wants to merge 14 commits into from
Closed

Adding a Neo4j GIE #34

wants to merge 14 commits into from

Conversation

thobalose
Copy link

@thobalose thobalose commented Jun 25, 2016

The Neo4j IE described in this issue.

Thanks to @bgruening and @erasche.

@@ -106,6 +106,7 @@ def launch_proxy_command(self, config):
"--sessions", config.proxy_session_map,
"--ip", config.dynamic_proxy_bind_ip,
"--port", str(config.dynamic_proxy_bind_port),
"--cookie", "galaxysession",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? That should be default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been whilst debugging the issues with proxy_ipc. Having seen and noting that it's not present when galaxy launched the proxy.

@pvanheus
Copy link
Collaborator

For this code to work with the nginx proxy it needs this in the nginx.conf:

        #Neo4J
        location /gie_proxy/neo {
            proxy_pass http://localhost:8800/;
            proxy_redirect default;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
        }

        location /db/data {
            proxy_pass http://localhost:8800/db/data;
            proxy_redirect default;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
        }
  1. Does the first block clash with other IEs? I.e. will the proxy know to direct that message to the correct IE?
  2. The second block does not refer to /gie_proxy. This is because the AngularJS app that implements the Neo4j shell does calls to that URL - this is not configurable at present, but a PR should be made against the Neo4j code to make it configurable.

If this PR is being merged, we need to add this info the GIE docs.

@pvanheus
Copy link
Collaborator

A bit of testing suggests that (1) is causing an issue. To reproduce the problem:

  1. Start a Jupyter IE
  2. Start a Neo4j IE
  3. The Jupyter IE goes to "Not found" and control of the IE is lost from the side of Galaxy.

In other words, this IE doesn't play nicely with other IEs on the same server.

@bgruening
Copy link
Collaborator

As discussed this is a general IE issue at the moment, at least with the IE proxy, afaik.

@thobalose thobalose closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants