refactor: code structure #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfallin
reviewed
Jan 9, 2025
vados-cosmonic
force-pushed
the
refactor=code-structure
branch
2 times, most recently
from
7ccada1 to
a94ddd0
Compare
vados-cosmonic
force-pushed
the
refactor=code-structure
branch
6 times, most recently
from
614569e to
74bab02
Compare
This commit moves the C++ build files to the top level directory `src` inside the repo, to enable some differentiation between source code and other repo artifacts/files. A few changes are included to refactor the codebase - update cmake file references - rename justfile to Justfile - fix componentize.sh references in cmake & elsewhere - wpt builtin location Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
refactor=code-structure
branch
from
74bab02 to
1a9306c
Compare
andreiltd
reviewed
Jan 10, 2025
andreiltd
reviewed
Jan 10, 2025
vados-cosmonic
force-pushed
the
refactor=code-structure
branch
from
7e86377 to
6159629
Compare
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
refactor=code-structure
branch
from
6159629 to
d1f1908
Compare
|
Can you provide more information on the motivation behind this refactor? |
|
I'm asking because while most of it is mechanical, it does have enough moving parts that I'd want to review it in some detail, which would cost a bunch of time |
|
Sorry I noted a bit on Zulip here, but the basic idea was that the code was a little difficult to find, and the separation between scripts that I was supposed to use versus stuff used by The refactor occurred to me as I was trying to change how starling was componentized |
|
Closing for now -- hopefully we can revisit this maybe when some of the Rust enablement work lands! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the C++ code to be stored under
srcand updates build and machinery to match.