chore(ci): Update wasm32-wasi reference for Rust 1.84 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joonas Bergius <[email protected]>
|
Going to fold these into #312. |
calvinrp
pushed a commit
that referenced
this pull request
Jan 20, 2025
I noticed #311 was failing on the `diesel_cli` install step. Digging in a bit, I noticed the [`ubuntu-latest` runner image was changed](actions/runner-images#10636) to point from [Ubuntu 22.04, which has `libsqlite3-dev` installed by default](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#installed-apt-packages), to [Ubuntu 24.04 instead and that no longer includes `libsqlite3-dev` in the default apt packages](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#installed-apt-packages). This simply adjusts the features that are enabled from defaults to just `postgres`, which is what the CI workflow uses. Additionally I folded in the changes from #313: > Per the failure in #312, Rust 1.84 deprecated wasm32-wasi target, and thus it now needs to be set to either wasm32-wasip1 or wasm32-wasip2. > > I wasn't sure if we wanted to target p1 or p2, so I defaulted to p2, but happy to switch it to p1 if that's preferred. --------- Signed-off-by: Joonas Bergius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the failure in #312, Rust 1.84 deprecated
wasm32-wasitarget, and thus it now needs to be set to eitherwasm32-wasip1orwasm32-wasip2.I wasn't sure if we wanted to target
p1orp2, so I defaulted top2, but happy to switch it top1if that's preferred.