Merge pull request #8 from bzimmer/iter

moved activities iterator to package scope
bzimmer · Oct 18, 2021 · 2be3eb5 · 2be3eb5
2 parents 0150f4f + ebac8c6
commit 2be3eb5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/strava/activity.go b/strava/activity.go
@@ -159,7 +159,7 @@ func (s *ActivityService) Activities(ctx context.Context, spec activity.Paginati
 }
 
 // ActivitiesIter executes the iter function over the results of the channel
-func (s *ActivityService) ActivitiesIter(res <-chan *ActivityResult, iter ActivityIterFunc) error {
+func ActivitiesIter(res <-chan *ActivityResult, iter ActivityIterFunc) error {
 	for ar := range res {
 		if ar.Err != nil {
 			return ar.Err

diff --git a/strava/activity_test.go b/strava/activity_test.go
@@ -21,7 +21,7 @@ import (
 
 func readall(ctx context.Context, client *strava.Client, spec activity.Pagination, opts ...strava.APIOption) ([]*strava.Activity, error) {
 	var activities []*strava.Activity
-	err := client.Activity.ActivitiesIter(
+	err := strava.ActivitiesIter(
 		client.Activity.Activities(ctx, spec, opts...),
 		func(act *strava.Activity) (bool, error) {
 			activities = append(activities, act)