Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KnowledgeGraph builder #34

Merged
merged 23 commits into from
Jul 5, 2024
Merged

feat: KnowledgeGraph builder #34

merged 23 commits into from
Jul 5, 2024

Conversation

debrupf2946
Copy link
Collaborator

@debrupf2946 debrupf2946 commented Jul 2, 2024

The GraphRag folder contains codes that allow users to build a Knowledge Graph from documents.

@debrupf2946 debrupf2946 changed the title added GraphRag feat: KnowledgeGraph builder Jul 2, 2024
@kmehant
Copy link
Member

kmehant commented Jul 2, 2024

@debrupf2946 The README is poorly written with scant attention to grammar and formatting please update it.

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the folder GraphRag to snake case and give it informative naming such graph_rag_using_llamaindex etc

GraphRag/README.MD Outdated Show resolved Hide resolved
GraphRag/knowledgeGraph.py Outdated Show resolved Hide resolved
GraphRag/knowledgeGraph.py Outdated Show resolved Hide resolved
GraphRag/knowledgeGraph.py Outdated Show resolved Hide resolved
GraphRag/requirements.txt Outdated Show resolved Hide resolved
GraphRag/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require more changes.

@debrupf2946
Copy link
Collaborator Author

@debrupf2946 The README is poorly written with scant attention to grammar and formatting please update it.
Thank you for the review
I have updated the README.MD

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debrupf2946

Update your PR with more information description on the tooling and approach you have taken in this PR. Add screenshots of examples that you have tried with this contribution.

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update on review

GraphRag/README.MD Outdated Show resolved Hide resolved
Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all this to graph_rag/graph_builder folder instead of GraphRag look at my other comments that I have added now. Thanks

GraphRag/requirements.txt Outdated Show resolved Hide resolved
@debrupf2946
Copy link
Collaborator Author

graph_builder

Refactored codes to graph_rag/graph_builder

@kmehant kmehant self-requested a review July 5, 2024 04:29
Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmehant
Copy link
Member

kmehant commented Jul 5, 2024

@debrupf2946 update the PR with signed commit and we are good to go.

@kmehant kmehant merged commit daa3a95 into c2siorg:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants