-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: KnowledgeGraph builder #34
Conversation
…nowledge Graph from Documents
@debrupf2946 The README is poorly written with scant attention to grammar and formatting please update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the folder GraphRag to snake case and give it informative naming such graph_rag_using_llamaindex etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require more changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update your PR with more information description on the tooling and approach you have taken in this PR. Add screenshots of examples that you have tried with this contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update on review
…_path as a parameter,also formatted collab using black
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move all this to graph_rag/graph_builder
folder instead of GraphRag
look at my other comments that I have added now. Thanks
…h_rag/graph_builder
Refactored codes to graph_rag/graph_builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@debrupf2946 update the PR with signed commit and we are good to go. |
… to build Knowledge Graph from Documents
…put_dir_path as a parameter,also formatted collab using black
…to graph_rag/graph_builder
The GraphRag folder contains codes that allow users to build a Knowledge Graph from documents.