Updates the crystal version restriction #22
Conversation
|
@jwoertink thank you very much!! 😍 on travis it errored, complaining about |
|
We could give that a try. I'm not familiar with that shard. Another option could be to go with https://github.com/spider-gazelle/tasker which allows you to do |
|
I don't know how to tell Travis to ignore the crystal version. I also see that the Schedule shard still isn't updated. I opened up an issue, but I'm not sure how soon that will be updated. |
|
I opened up an issue on the Schedule shard hugoabonizio/schedule.cr#19 |
|
We are using Schedule only on https://github.com/cable-cr/cable/blob/master/src/cable/websocket_pinger.cr, we can change to tasker for sure.. choosing schedule was an arbitrary decision to have this task in parallel so yes, let's move to tasker and make it 1.0 ready, thanks for pushing this @jwoertink ! 🙇 |
|
Interesting... That failure doesn't happen locally. I wonder what's causing that 🤔 |
|
Ok, I was able to get this to fail locally. It looks like those two messages are just reversed. I guess the question here is, does that ordering matter? Or is it just a matter of checking that those specific messages are received? |
|
LOL! Ok, this is a little ridiculous... If I focus that spec, I can get it to fail locally. So then I swap those two lines, it passes. Then I run the entire suite, and it fails 🤦 This leads me to believe that it's a race condition. I'll update it so it just checks that those lines are in the messages, but not really care about the order. |
| Cable::Logger.messages.should contain("ChatChannel is streaming from chat_1") | ||
| Cable::Logger.messages.should contain("ChatChannel is transmitting the subscription confirmation") | ||
| Cable::Logger.messages.should contain("RejectionChannel is transmitting the subscription rejection") | ||
| Cable::Logger.messages.should contain("[ActionCable] Broadcasting to chat_1: {\"foo\" => \"bar\"}") | ||
| # and here we can confirm the message was broadcasted | ||
| Cable::Logger.messages[4].should eq("[ActionCable] Broadcasting to rejection: {\"foo\" => \"bar\"}") | ||
| Cable::Logger.messages[5].should eq("ChatChannel transmitting {\"foo\" => \"bar\"} (via streamed from chat_1)") | ||
| Cable::Logger.messages.should contain("ChatChannel transmitting {\"foo\" => \"bar\"} (via streamed from chat_1)") | ||
| Cable::Logger.messages.should contain("[ActionCable] Broadcasting to rejection: {\"foo\" => \"bar\"}") |
There was a problem hiding this comment.
The last 2 [4] and [5] seem to randomly swap. I'm not sure if the order really matters here, or if it just matters that they exist.
|
TYVM @jwoertink !! 👏 👏 👏 |
I ran the specs locally against Crystal 1.0, and they pass:
I'm not sure how to add multiple crystal versions to Travis CI, but by updating this crystal version restriction, it can be resolved with other shards between 0.35 and 1.0.