-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multicomponent Freundlich LDF isotherm. #259
Conversation
For reference, here's the current state of the documentation. A multi-component extension to the classical Freundlich adsorption model. $ Here, For more information on model parameters required to define in CADET file format, see :ref:
|
I got some comments from collaborators, so this PR will need work before it can be merged. I can take care of it after my return but I'll also forward you the email. Can't do much more from my phone atm. |
aeb3281
to
3dea786
Compare
Also adapt parameter units based on feedback by Benedikt Aumeier.
3dea786
to
354706a
Compare
The typos have been fixed and this is imo ready for review. |
Reviewing this, it just came to my attention that many binding tests are actually not part of the CI, right? e.g. the one defined here in this PR.. |
This PR continues work by @sleweke to add the multicomponent Freundlich isotherm to CADET-Core.
I've rebased the branch onto master.
Status and ToDos:
The Freundlich isotherm works in all tests configurations I threw at it (both components c_p > 1, cp == 0 and cp < 0).