-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multicomponent Sips isotherm. #260
Conversation
For reference, here's the current state of the documentation: Multi Component Sips
|
43f9a60
to
0d62554
Compare
e74b0be
to
4663151
Compare
wait a minute why is the CI failing when ive only updated the copyright.. ive seen this before .. |
That's unrelated. It's because of my error with the commit I've accidentally made to master, that is now #358 edit: No, nevermind, it's not. But it also happens on that other PR. edit2: Yes, it might be, because the line in the log that throws the error is the one I changed. Will report back with more detail. edit3: Yes, it was unrelated due to the changes in #358 . After re-running the CI it now completes fine. |
241f97f
to
8ea9b92
Compare
I think we should keep a separate commit for changes in the freundlich isotherm and squash the rest into another commit? |
I'll keep the commit by Sam as-is to retain authorship, squash all Sips made by me into one and all Freundlich by me into one. |
You can also squash them all into Sams, then add yourself as co author by adding the following to the commit description: |
8ea9b92
to
86d5c42
Compare
Based on changes made by [email protected] Convert Sips to standard for Freundlich isotherms in CADET, which is ^(1/n) instead of ^n Improve stability by extending linearization range into negative numbers Update documentation Update units in documentation Extend tests Co-authored-by: Ronald Jäpel <[email protected]>
Extend linearization range into negative numbers to improve stability Extend tests Update documentation
86d5c42
to
53ca6ab
Compare
Is squashed. Ready to merge |
This PR continues work by @sleweke to add the multicomponent Sips isotherm to CADET-Core.
I've rebased the branch onto master and added several changes to documentation and tests.
Status and ToDos:
Reference is Sips, R.: On the structure of a catalyst surface. J. Chem. Phys. 16, 490–495 (1948)