You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation change of taking the absolute value of $c_p$ is to prevent negative concentrations from crashing the simulation. This can happen if $1/n$ is chosen such that it leads to an even root being taken of $c_p$, e.g. $n=2$.
The linearization that we have implemented for small concentrations (to stabilize the derivative for $c_p \approx 0$) could also be used to stabilize the negative concentrations.
Should we update the documentation to match the implementation or update the implementation to use the linearization for small and negative $c_p$ values?
The Freundlich isotherm is documented as:
but is implemented as
The implementation change of taking the absolute value of$c_p$ is to prevent negative concentrations from crashing the simulation. This can happen if $1/n$ is chosen such that it leads to an even root being taken of $c_p$ , e.g. $n=2$ .
The linearization that we have implemented for small concentrations (to stabilize the derivative for$c_p \approx 0$ ) could also be used to stabilize the negative concentrations.
Should we update the documentation to match the implementation or update the implementation to use the linearization for small and negative$c_p$ values?
@lieres what do you think?
The text was updated successfully, but these errors were encountered: