Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testRunner #70

Closed
jayghoshter opened this issue May 5, 2021 · 2 comments · Fixed by #155
Closed

Fix testRunner #70

jayghoshter opened this issue May 5, 2021 · 2 comments · Fixed by #155

Comments

@jayghoshter
Copy link
Member

Running testRunner locally on my machine results in several failures. I've tested this from commit a3216c4 to 44e0f81, taking the last commit from a batch of commits around similar time periods.

I didn't go beyond a3216c4 since my environment had the newest CMake, which required that commit to fix the HDF5 target issue.

@jayghoshter jayghoshter changed the title testRunner fails Fix testRunner May 5, 2021
@schmoelder schmoelder added this to the v4.2.0 milestone May 5, 2021
@schmoelder
Copy link
Contributor

schmoelder commented May 6, 2021

To do

  • Decide which tests to include in CI (using flag)
  • Disable Jacobian tests for the colloidal one (or better, fix the jacobian!)
  • Decide how to handle subtle differences due to platform or parallelization in the linear algebra and floating point (decided to only run tests on one platform) computations.

@jbreue16
Copy link
Contributor

jbreue16 commented Dec 11, 2023

We need to revisit this issue as more and more developers are working on CADET (e.g. MCT, DG, Crystallization) and tests become substantial to not only ensure the numerics are correct and functional but to keep CADET maintainable.
We have failing tests of three categories: Unsupported functionality is tested; Test script was not maintained; Implementation flaws
The first category should be commented out, the second fixed, and the third kept but excluded from CI and documented in an Issue.

This issue is addressed in PR #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants