Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and expand tests #155

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fix and expand tests #155

merged 2 commits into from
Mar 22, 2024

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Dec 13, 2023

We have failing tests for different reasons: Some tests were not maintained, FD tolerances too strict (might depend on system), Unsupported functionality is tested.

To do

Fixes #70.

Furthermore, we want to expand our tests according to #167
Todo:

  • enable h5 reader in testrunner (Add h5 to testrunner and use static libraries in debug mode #172 )
  • numerical reference solution tests
    • reference data in h5 files, setup data in json (which can later be read from CADET-Database, CADET-reference)
    • add meta data to reference data (source, name, info/description (hash will come in the future with CADET-database))
      • model setups (will be updated by CADET-Database in the future)
    • Non-linear bindings for all chromatography units (numerical reference): LWE
    • experimental convergence order (EOC) tests
  • analytical Jacobian tests for all units using AD
  • create CADET-RDM project with python code that creates the reference data

@jbreue16 jbreue16 mentioned this pull request Dec 13, 2023
@jbreue16 jbreue16 changed the title Fix tests Fix and expand tests Mar 1, 2024
@jbreue16 jbreue16 force-pushed the fix/tests branch 3 times, most recently from c1076bd to d8b42e0 Compare March 7, 2024 12:12
@jbreue16 jbreue16 force-pushed the fix/tests branch 3 times, most recently from 4b52bc8 to 0f98d5c Compare March 22, 2024 08:53
@jbreue16 jbreue16 requested a review from schmoelder March 22, 2024 09:00
@jbreue16 jbreue16 force-pushed the fix/tests branch 3 times, most recently from 69728d6 to b90a7c0 Compare March 22, 2024 11:42
Add full model AD Jacobian tests

Fix non-maintained tests

Add numerical reference

Add numerical EOC tests
@jbreue16 jbreue16 merged commit f6ca044 into cadet:master Mar 22, 2024
3 checks passed
@jbreue16 jbreue16 mentioned this pull request Jul 26, 2024
42 tasks
@jbreue16 jbreue16 added the test label Aug 28, 2024
@jbreue16 jbreue16 self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix testRunner
2 participants