Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/flux structure #184

Closed
wants to merge 1 commit into from
Closed

Fix/flux structure #184

wants to merge 1 commit into from

Conversation

schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Mar 29, 2024

The ordering of the flux was not consistent with other solution types. For a consistent interface, this PR reorders the flux structure.

Since flux is hardly used by anyone, I believe a breaking change is justifiable.

@sleweke: Is it enough to change the solution layout or do we also need to restructure the contents of the state vector?

@schmoelder
Copy link
Contributor Author

I was wrong.

bulk: 'nTime', ('nAxialCells',) ('nRadialCells' / 'nPorts',) 'nComp'
particle_liquid: 'nTime', ('nParTypes',) ('nAxialCells',) ('nRadialCells' / 'nPorts',) ('nParShells',) 'nComp'
particle_solid: 'nTime', ('nParTypes',) ('nAxialCells',) ('nRadialCells' / 'nPorts',) ('nParShells',) 'nComp', 'nBound'
flux: 'nTime', ('nParTypes',) ('nAxialCells',) ('nRadialCells' / 'nPorts',) 'nComp'

@schmoelder schmoelder closed this Apr 19, 2024
@jbreue16 jbreue16 deleted the fix/flux_structure branch May 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant