Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max result rows by default #34

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

thiagodsti
Copy link
Contributor

@thiagodsti thiagodsti commented Nov 1, 2024

In order to make this work just as the clickhouse playground I set default values for: max_result_rows, max_result_bytes and result_overflow_mode.

Screenshot 2024-11-01 at 15 28 43

@caioricciuti
Copy link
Owner

Hey @thiagodsti good one, the only thing that I'm worried about is that my queries and some clients that use CH-UI expect much more than 1000 rows, I'll see if I can add on the admin page a setting that can change that. Then we can merge, sounds good?

@thiagodsti
Copy link
Contributor Author

oh makes sense I can do that i'll add to the admin page

@caioricciuti caioricciuti merged commit 4cb612e into caioricciuti:main Nov 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants