.

src/application/objects/asteroid_large.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 // include order relevant
 #include "../configuration.hpp"

src/application/objects/asteroid_medium.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 // include order relevant
 #include "../configuration.hpp"

src/application/objects/asteroid_small.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 // include order relevant
 #include "../configuration.hpp"
@@ -10,9 +11,9 @@
 //
 #include "../utils.hpp"
 
-static uint64_t power_up_soonest_next_spawn_ms = 0;
-
 class asteroid_small final : public object {
+  static inline uint64_t power_up_soonest_next_spawn_ms = 0;
+
 public:
   inline asteroid_small() {
     if (debug_multiplayer) {

src/application/objects/cube.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 class cube final : public object {
 public:

src/application/objects/fragment.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 class fragment final : public object {
 public:

src/application/objects/power_up.hpp

@@ -2,10 +2,15 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 #include "../utils.hpp"
 
 class power_up final : public object {
+  uint64_t death_time_ms = 0;
+  uint64_t scale_time_ms = 0;
+  bool scale_up = false;
+
 public:
   inline power_up() {
     if (debug_multiplayer) {
@@ -66,9 +71,4 @@ class power_up final : public object {
 
     return false;
   }
-
-private:
-  uint64_t death_time_ms = 0;
-  uint64_t scale_time_ms = 0;
-  bool scale_up = false;
 };

src/application/objects/ship.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 #include "ship_bullet.hpp"
 
@@ -21,6 +22,8 @@ static uint32_t constexpr bullet_levels_length =
 static uint32_t bullet_levels_index = 0;
 
 class ship final : public object {
+  uint64_t ready_to_fire_at_ms = 0;
+
 public:
   inline ship() {
     if (debug_multiplayer) {
@@ -30,7 +33,7 @@ class ship final : public object {
              name.c_str());
     }
     glob_ix(glob_ix_ship);
-    scale = {1, 1, 1};
+    scale = {1.0f, 1.0f, 1.0f};
     bounding_radius = glob().bounding_radius * scale.x;
     mass = 150;
     collision_bits = cb_hero;
@@ -87,6 +90,7 @@ class ship final : public object {
       camera.look_at = {0, 0, -.000001f};
       // note: -.000001f because of the math of 'look at'
     }
+
     return true;
   }
 
@@ -142,6 +146,4 @@ class ship final : public object {
     }
     ready_to_fire_at_ms = frame_context.ms + bl.fire_interval_ms;
   }
-
-  uint64_t ready_to_fire_at_ms = 0;
 };

src/application/objects/ship_bullet.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 #include "fragment.hpp"
 
@@ -15,7 +16,7 @@ class ship_bullet final : public object {
              name.c_str());
     }
     glob_ix(glob_ix_bullet);
-    scale = {1, 1, 1};
+    scale = {1.0f, 1.0f, 1.0f};
     bounding_radius = glob().bounding_radius * scale.x;
     mass = 5;
     collision_bits = cb_hero_bullet;

src/application/objects/sphere.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 class sphere final : public object {
 public:

src/application/objects/tetra.hpp

@@ -2,6 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
+// reviewed: 2024-07-15
 
 class tetra final : public object {
 public:

src/application/objects/ufo.hpp

@@ -1,4 +1,5 @@
 #pragma once
+// reviewed: 2024-07-15
 
 #include "ufo_bullet.hpp"
 
@@ -45,8 +46,8 @@ class ufo final : public object {
       next_fire_ms = frame_context.ms + ufo_fire_rate_interval_ms;
       if (hero) {
         ufo_bullet *ub = new (objects.alloc()) ufo_bullet{};
-        vec3 dir = normalize(hero->position - position);
         ub->position = position;
+        vec3 const dir = normalize(hero->position - position);
         ub->velocity = ufo_bullet_velocity * dir;
       }
     }

src/application/objects/ufo_bullet.hpp

@@ -1,4 +1,5 @@
 #pragma once
+// reviewed: 2024-07-15
 
 #include "fragment.hpp"
 

src/application/utils.hpp

@@ -2,10 +2,7 @@
 // reviewed: 2024-01-04
 // reviewed: 2024-01-08
 // reviewed: 2024-07-08
-
-// include order matters
-#include "configuration.hpp"
-//
+// reviewed: 2024-07-15
 
 inline static auto rnd1(float const range) -> float {
   int const r = rand();