fix(text): variant loss with child component #4173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a component is used as a child to Text i.e.
<Text><MyComponent /></Text>
the variant specified in the text is ignored.i.e.
This is due to logic inside of the Text component trying to deal with nested Text components. This logic however applies to all components and breaks rendering components within Text.
Related issue
#4172
Test plan
Text.test.tsx
contains tests for regressions - nested text with variant should override parent's variantText.test.tsx
- nested non-text component should not override parent's variantBefore
After