-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql 10 with postgis 2.4 #8
Conversation
should be |
rename done |
Time to move to travis-ci for build to use ARGS ? |
@tcoupin I can't see the point of having multiple images if we don't have to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the ARGS directive and install all PostGIS supported versions
Having multiple version is useful for integration tests against multiple environments.
You can also support other architecture since official image support amd64, arm32v5, arm32v6, arm32v7, arm64v8, i386, ppc64le and s390x. |
Don't install all posgis version in the same image, it's not container philosophy "keep it small" |
@tcoupin I don't agree to change only for 10.0, please provide a PR for adding PostgreSQL 10.0 support the same way we do for 9.5 and 9.6 (this one I'll merge ASAP) and another PR with a proposal for changing the way we do for all PostgreSQL versions (this one will need a little bit more discussion). |
Update done, I open the #9 for discussion |
@tcoupin thanks. |
postgis 2.4 for older postgresql versions are builded again GEOS 3.4 but some functions like ST_VoronoiPolygons need GEOS >=3.5.0