Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql 10 with postgis 2.4 #8

Merged
merged 1 commit into from
Nov 5, 2017
Merged

postgresql 10 with postgis 2.4 #8

merged 1 commit into from
Nov 5, 2017

Conversation

tcoupin
Copy link
Contributor

@tcoupin tcoupin commented Nov 2, 2017

postgis 2.4 for older postgresql versions are builded again GEOS 3.4 but some functions like ST_VoronoiPolygons need GEOS >=3.5.0

@fredj
Copy link
Member

fredj commented Nov 2, 2017

should be 10.0 (directory) instead of 10 (and also FROM postgres:10.0 instead of FROM postgres:10)

@tcoupin
Copy link
Contributor Author

tcoupin commented Nov 2, 2017

rename done

@fredj
Copy link
Member

fredj commented Nov 2, 2017

@mcanevet, @mbornoz, @sbrunner any comment on this?

@mcanevet
Copy link
Contributor

mcanevet commented Nov 2, 2017

@tcoupin @fredj isn't it possible to install all Postgis versions like we do with postgres 9.5 and 9.6?
I'd prefer to have almost the same Dockerfile on all supported versions.
I can't see how the ARGS directive could be passed to DockerHub to build different images

@tcoupin
Copy link
Contributor Author

tcoupin commented Nov 2, 2017

Time to move to travis-ci for build to use ARGS ?

@mcanevet mcanevet self-requested a review November 2, 2017 16:11
@mcanevet
Copy link
Contributor

mcanevet commented Nov 2, 2017

@tcoupin I can't see the point of having multiple images if we don't have to.
What would be the image name in that case?

Copy link
Contributor

@mcanevet mcanevet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the ARGS directive and install all PostGIS supported versions

@tcoupin
Copy link
Contributor Author

tcoupin commented Nov 2, 2017

Having multiple version is useful for integration tests against multiple environments.
For names, just follow officials images tag rules:

  • latest, 10, 10.0, 10-pgis2.4, 10.0-pgis2.4, pgis2.4
  • 9, 9.6, 9-pgis2.4, 9.6-pgis2.4, 9-pgis2.3, 9.6-pgis2.3, 9-pgis2.2, 9.6-pgis2.2
    ...

You can also support other architecture since official image support amd64, arm32v5, arm32v6, arm32v7, arm64v8, i386, ppc64le and s390x.

@tcoupin
Copy link
Contributor Author

tcoupin commented Nov 3, 2017

Don't install all posgis version in the same image, it's not container philosophy "keep it small"

@mcanevet
Copy link
Contributor

mcanevet commented Nov 3, 2017

@tcoupin I don't agree to change only for 10.0, please provide a PR for adding PostgreSQL 10.0 support the same way we do for 9.5 and 9.6 (this one I'll merge ASAP) and another PR with a proposal for changing the way we do for all PostgreSQL versions (this one will need a little bit more discussion).

@tcoupin
Copy link
Contributor Author

tcoupin commented Nov 4, 2017

Update done, I open the #9 for discussion

@mcanevet mcanevet merged commit 0941877 into camptocamp:master Nov 5, 2017
@mcanevet
Copy link
Contributor

mcanevet commented Nov 5, 2017

@tcoupin thanks.
Build in progress on DockerHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants