Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider viewers via camunda-bpmn-js #110

Closed
MaxTru opened this issue Apr 5, 2022 · 2 comments
Closed

Provider viewers via camunda-bpmn-js #110

MaxTru opened this issue Apr 5, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Apr 5, 2022

Is your feature request related to a problem? Please describe.

At the moment, camunda-bpmn-js only exposes a distribution of the bpmn-js modeler (ie. include moddle, propPanel, ...).

With recent changes (in particular custom icon renderer cf. #108), also consumers of a viewer (viewer or navigatedViewer) need to include custom modules to have the desired end-2-end experience.

At the moment, they would need to manually build their bpmn-js viewer consiting of bpmn-js#viewer, moddle, customRendererModule.

Describe the solution you'd like

Offer a viewer and navigatedViewer component for camunda bpmn-js which would include the respective moddle, and the custom renderer component (c.f. #108). Maybe even more.

Describe alternatives you've considered

  • Keep as is.
  • Make custom icon renderer bpmn-js core concern.

Additional context

Raised within #108

@MaxTru MaxTru added the enhancement New feature or request label Apr 5, 2022
@pinussilvestrus
Copy link
Contributor

Is this a duplicate of: #4? Maybe we can merge both issues with the new information we've got.

@MaxTru
Copy link
Contributor Author

MaxTru commented Apr 5, 2022

Closing as duplicate of #4 indeed :-)

@MaxTru MaxTru closed this as completed Apr 5, 2022
@MaxTru MaxTru added the duplicate This issue or pull request already exists label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants