-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate template icons #108
Conversation
bffad14
to
1652784
Compare
This is waiting for a new properties panel release, but I think we can still wait for the other improvements to be merged, e.g. bpmn-io/bpmn-js-properties-panel#648 Maybe we can simply use this branch for the overall version bumps before the release /cc @MaxTru @marstamm |
The way the icons are implemented means:
Do we intend to keep (3)? Perhaps the icons renderer should be required as a part of the element templates module -> to be extracted to a separate element templates package in the future. |
I thought about this one and given the current situation (element-templates as part of the properties panel) I found it strange to include rendering parts in the properties panel. However, I'd love to see the element templates be a standalone module. We should definitely tackle this in Q2 IMHO. |
@pinussilvestrus is out sick today, but this is super well prepared and the dependencies are met. I am marking this as ready for review. |
We need to release and integrate another alpha of bpmn-js-properties-panel to merge it. |
Back to draft. I realized, we should also bump prop-panel to integrate the latest fix |
Back to draft, waiting until we have https://camunda.slack.com/archives/CKGH9LR40/p1649155653797739 fixed |
Closes #106
Depends on bpmn-io/element-template-icon-renderer#2
Depends on bpmn-io/bpmn-js-properties-panel#641