Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Viewer and NavigatedViewer for each module #4

Closed
6 tasks
pinussilvestrus opened this issue Feb 3, 2021 · 2 comments · Fixed by #115
Closed
6 tasks

Provide Viewer and NavigatedViewer for each module #4

pinussilvestrus opened this issue Feb 3, 2021 · 2 comments · Fixed by #115
Assignees
Labels
enhancement New feature or request

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Feb 3, 2021

Is your feature request related to a problem? Please describe.

Currently, this project only serves the modeling capabilities of the distributions. However, we should consider users want to render only, e.g. via Viewer or NavigatedViewer.

With recent changes (in particular custom icon renderer cf. #108), this might be in particular important and relevant. Otherwise consumers of a viewer (viewer or navigatedViewer) need to include custom modules to have the desired end-2-end experience.

Describe the solution you'd like

Provide

  • base
    • Viewer
    • NavigatedViewer
  • camunda-cloud
    • Viewer
    • NavigatedViewer
  • camunda-platform
    • Viewer
    • NavigatedViewer

Describe alternatives you've considered

/

Additional context

/

@pinussilvestrus pinussilvestrus added enhancement New feature or request backlog Queued in backlog labels Feb 3, 2021
@MaxTru MaxTru added the ready Ready to be worked on label Apr 12, 2022 — with bpmn-io-tasks
@MaxTru MaxTru removed the backlog Queued in backlog label Apr 12, 2022
@MaxTru
Copy link
Contributor

MaxTru commented Apr 12, 2022

Let's also inform other teams of the change once we have it

@marstamm
Copy link
Member

Seeing that most of the modules are modeling modules and from the use case of the modeler in embedded applications without a minimap, I see the following modules:

  • base viewer
    • default viewers from bpmn-js
  • cloud viewer
    • disable drilldown
    • iconRenderer
    • zeebeModdle
  • platform viewer
    • camundaModdle

The moddle extension is not necessary as of now, but always good to have it anyway. We will also provide bundled CSS for the viewers so it is not necessary to include multiple CSS files (diagram-js.css + bpmn-js.css)

marstamm added a commit that referenced this issue Apr 13, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Apr 13, 2022
marstamm added a commit that referenced this issue Apr 13, 2022
marstamm added a commit that referenced this issue Apr 13, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 13, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 19, 2022
marstamm added a commit that referenced this issue Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants