Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ootbc): Add headers property to kafka connector #2758

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Oleksiivanov
Copy link
Contributor

@Oleksiivanov Oleksiivanov commented Oct 17, 2023

Description

Add headers property to kafka connector

Related :

When should this change go live?

14, November, 2023

  • This change is not yet live and should not be merged until 14, November, 2023 (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory
  • I have added changes to the main /docs directory (aka /next/)
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer.

@Oleksiivanov Oleksiivanov added the hold This issue is parked, do not merge. label Oct 17, 2023
@Oleksiivanov Oleksiivanov self-assigned this Oct 17, 2023
@Oleksiivanov Oleksiivanov marked this pull request as ready for review October 18, 2023 06:56
@christinaausley christinaausley added the component:connectors Issues related to the connectors project. label Oct 18, 2023
@akeller
Copy link
Member

akeller commented Oct 31, 2023

Hi there!

We are in the process of archiving 8.0 docs since this version has reached the end of maintenance. You must remove changes to 8.0 docs since they will not exist in our main docs but will be moved to a static site.

Additionally, you'll need to "backport" your changes to version-8.3 as it was released a few weeks ago.

@christinaausley
Copy link
Contributor

@Oleksiivanov Is this still a WIP and/or will you need this merged before release next week? I noticed the Connectors issue is closed.

@Oleksiivanov
Copy link
Contributor Author

Oleksiivanov commented Nov 10, 2023

@Oleksiivanov Is this still a WIP and/or will you need this merged before release next week? I noticed the Connectors issue is closed.

I updated description. It can be merged (deployed) only after release (November 14). I will move to ready for review, when I update/correct this PR.

@Oleksiivanov Oleksiivanov marked this pull request as draft November 10, 2023 13:59
@Oleksiivanov Oleksiivanov marked this pull request as ready for review November 10, 2023 14:04
@christinaausley
Copy link
Contributor

@Oleksiivanov I'll push out a release this evening and/or tomorrow morning, so feel free to go ahead and merge when ready 👍

@christinaausley christinaausley removed the hold This issue is parked, do not merge. label Nov 13, 2023
@Oleksiivanov Oleksiivanov merged commit ebf6806 into main Nov 13, 2023
@Oleksiivanov Oleksiivanov deleted the kafka_add_headers branch November 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Kafka Connector - Add ability to read and write headers
4 participants