Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update element templates docs #2789

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Update element templates docs #2789

merged 3 commits into from
Feb 28, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Feb 28, 2022 •
edited
Loading

Closes #2723
Built on top #2785

  • updates docs
    • update $schema attribute, required for Camunda Cloud
    • update latest supported $schema versions
    • split up binding docs
    • add Camunda Cloud bindings
    • add optional bindings
    • add groups
    • add entriesVisible
  • update samples
  • update screenshots

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 28, 2022
@pinussilvestrus
Copy link
Contributor Author

@MaxTru all the necessary changes should be included. Although it's waiting for #2785 to be merged, feel free to already have a look.

MaxTru
MaxTru reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Only minor comments

resources/element-templates/samples.json Outdated Show resolved Hide resolved
docs/element-templates/README.md Outdated Show resolved Hide resolved
docs/element-templates/README.md Show resolved Hide resolved
docs/element-templates/README.md Outdated Show resolved Hide resolved
@pinussilvestrus pinussilvestrus force-pushed the 2723-update-element-templates-docs branch from ef83df3 to f4445b2 Compare February 28, 2022 16:37
Base automatically changed from 2731-rollout-cloud-templates to develop February 28, 2022 16:41
@pinussilvestrus pinussilvestrus marked this pull request as ready for review February 28, 2022 16:42
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 28, 2022
Niklas Kiefer added 3 commits February 28, 2022 17:43
docs(element-templates): update documentation
c1a381a 
Closes #2723

* update `$schema` attribute, required for Camunda Cloud
* update latest supported `$schema` versions
* split up binding docs
* add Camund Cloud bindings
* add optional bindings
* add groups
* add entriesVisible
chore(element-templates): update samples
8632832
docs(element-templates): update screenshots
fee00e2
@pinussilvestrus pinussilvestrus force-pushed the 2723-update-element-templates-docs branch from f4445b2 to fee00e2 Compare February 28, 2022 16:43
@pinussilvestrus
Copy link
Contributor Author

Rebased on develop and adjusted the things you mentioned @MaxTru.

MaxTru
MaxTru approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@pinussilvestrus pinussilvestrus merged commit 855afae into develop Feb 28, 2022
@pinussilvestrus pinussilvestrus deleted the 2723-update-element-templates-docs branch February 28, 2022 17:15
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update element template docs
2 participants
@pinussilvestrus @MaxTru