Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing tenantId to Camunda 8 self-managed #3826

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Allow passing tenantId to Camunda 8 self-managed #3826

merged 5 commits into from
Oct 31, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Sep 1, 2023 •
edited by philippfromme
Loading

This adds visual editing of tenantId. We keep the existing pattern that tenantId is maintained with the deployment, and simply carried over by the run tool.

capture yWcH2o_optimized

TODO

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 1, 2023
@nikku nikku changed the base branch from develop to debug-logging September 1, 2023 13:10
@nikku nikku added this to the 8.3 milestone Sep 1, 2023
@nikku nikku mentioned this pull request Sep 1, 2023
Closed
6 tasks
Base automatically changed from debug-logging to develop September 11, 2023 08:12
@nikku nikku force-pushed the support-tenantId branch 4 times, most recently from 2b6f33b to 491a3c1 Compare September 18, 2023 10:25
nikku
nikku commented Sep 18, 2023
View reviewed changes
Copy link
Member Author

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now ready for an initial review.

@nikku nikku added the needs review Review pending label Sep 18, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Sep 18, 2023
@nikku
Copy link
Member Author

nikku commented Sep 18, 2023 •
edited
Loading

This can be tested by starting the modeler with DEBUG=1 flag, so that it debug logs communication with Zeebe:

capture JB0oaQ_optimized

@nikku nikku added the backlog Queued in backlog label Sep 22, 2023 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Sep 22, 2023
@nikku nikku added the ready Ready to be worked on label Oct 18, 2023 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Oct 18, 2023
@nikku nikku modified the milestones: 8.4, M70 Oct 18, 2023
@nikku nikku assigned philippfromme and unassigned nikku Oct 20, 2023
@philippfromme philippfromme force-pushed the support-tenantId branch 3 times, most recently from 390659e to e006c28 Compare October 26, 2023 13:37
@philippfromme philippfromme marked this pull request as ready for review October 27, 2023 07:39
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Oct 27, 2023
@philippfromme philippfromme marked this pull request as draft October 27, 2023 07:40
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 27, 2023
@philippfromme
feat: implement tenantId support
c286acf 
Co-authored-by: Nico Rehwaldt <[email protected]>

* be able to configure `tenantId` for C8 self-managed
@philippfromme philippfromme marked this pull request as ready for review October 30, 2023 08:23
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 30, 2023
barmac
barmac approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippfromme philippfromme requested a review from barmac October 31, 2023 09:06
@philippfromme philippfromme merged commit 2fff9e6 into develop Oct 31, 2023
@philippfromme philippfromme deleted the support-tenantId branch October 31, 2023 09:06
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm Awaiting requested review from marstamm

@smbea smbea Awaiting requested review from smbea

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
M70
Development

Successfully merging this pull request may close these issues.
3 participants
@nikku @barmac @philippfromme