fix(inbound): fix saving already processed process definition keys #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igpetrov
approved these changes
Feb 1, 2024
igpetrov
approved these changes
Feb 1, 2024
Oleksiivanov
approved these changes
Feb 1, 2024
sbuettner
approved these changes
Feb 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markfarkas-camunda
deleted the
1881-Imported-process-definitions-should-not-be-added-to-registeredProcessDefinitionKeys-before-handling-them
branch
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
/backport |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.3
git worktree add -d .worktree/backport-1883-to-release/8.3 origin/release/8.3
cd .worktree/backport-1883-to-release/8.3
git switch --create backport-1883-to-release/8.3
git cherry-pick -x fb09ab5688bb30c1f065bfb9b971f294e6e8810f |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.4
git worktree add -d .worktree/backport-1883-to-release/8.4 origin/release/8.4
cd .worktree/backport-1883-to-release/8.4
git switch --create backport-1883-to-release/8.4
git cherry-pick -x fb09ab5688bb30c1f065bfb9b971f294e6e8810f |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We changed the way we interact with Operate, so it won't throw OperateException anymore, so I made the exception catching generic.
Had to move where we add the process definition keys to the registeredProcessDefinitionKeys set, in order to avoid potential issue (see details in the ticket)
Related issues
closes #
#1881