Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(mail-connector): Backport 3796 to release/8.6 smtp body validation #3820

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

itsnuyen
Copy link
Contributor

Description

Cherry Pick the bugfix to validate htmlBody and textBody

Related issues

closes ##3795

Checklist

  • PR has a milestone or the no milestone label.

itsnuyen and others added 2 commits December 19, 2024 11:33
…error (#3796)

* fix(mail-connector): check htmlBody and/or body is null and throw an error
if not throw an error, connector will retry it over and over again.

* chore(mail-connector): build the assertation inside the `SmtpSendMail` record

* test(mail-connector): adding unit test to validate `isEmailMessageValid`

* chore(mail-connector): run mvn spotless to format the `SmtpSendEmailTest` class

* chore(mail-connector): use mvn:licence to add the licence to the file

(cherry picked from commit 657810f)
@itsnuyen itsnuyen self-assigned this Dec 19, 2024
@itsnuyen itsnuyen marked this pull request as ready for review December 19, 2024 13:42
@itsnuyen itsnuyen requested a review from a team as a code owner December 19, 2024 13:42
@mathias-vandaele mathias-vandaele merged commit d5104d8 into release/8.6 Dec 20, 2024
6 checks passed
@mathias-vandaele mathias-vandaele deleted the backport-3796-to-release/8.6 branch December 20, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants