refactor(camunda-client): replace zeebe-client by camunda-client #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -86,8 +86,8 @@ | |||
| } | |||
|
|
|||
| @SuppressWarnings({"rawtypes", "unchecked"}) | |||
| public ZeebeFuture<ProcessInstanceEvent> send() { | |||
| ZeebeClientFutureImpl future = new ZeebeClientFutureImpl<>(); | |||
| public CamundaFuture<ProcessInstanceEvent> send() { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note test
| @@ -140,7 +141,7 @@ | |||
| new ProcessDefinitionVersion( | |||
| processDef.getProcessDefinitionKey(), processDef.getVersion())))); | |||
|
|
|||
| var bpmnTest = ZeebeTest.with(zeebeClient).deploy(model).createInstance(); | |||
| var bpmnTest = ZeebeTest.with(camundaClient).deploy(model).createInstance(); | |||
Check notice
Code scanning / CodeQL
Unread local variable Note test
mathias-vandaele
changed the title
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
mathias-vandaele
force-pushed
the
3807-update-zeebe-java-client-to-new-camunda-java-client-artifact-name-change
branch
from
19c270b to
b494f5a
Compare
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
…-java-client-artifact-name-change
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
johnBgood
reviewed
Jan 10, 2025
| Map<String, Object> customProperties) | ||
| Map<String, Object> customProperties, | ||
| String processDefinitionId, | ||
| Long processInstanceKey) |
There was a problem hiding this comment.
why is that not in main already?
Co-authored-by: Jonathan <[email protected]>
github-actions
bot
temporarily deployed
to
connectors-3807-update-zee-c8sm
mathias-vandaele
deleted the
3807-update-zeebe-java-client-to-new-camunda-java-client-artifact-name-change
branch
|
/backport |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.7
git worktree add -d .worktree/backport-3826-to-release/8.7 origin/release/8.7
cd .worktree/backport-3826-to-release/8.7
git switch --create backport-3826-to-release/8.7
git cherry-pick -x 611bcfe4df88e77e36a242b5e3f5dd12387ee270 |
johnBgood
pushed a commit
that referenced
this pull request
Jan 10, 2025
* refactor(camunda-client): 1st commit, further investigation needed merging * refactor(camunda-client): fixing the issue, refactor is done * refactor(camunda-client) bring a single camunda version * refactor(camunda-client) bring a single camunda version 5 * refactor(camunda-client) bring a single camunda version 6 * Update connectors/http/rest/README.peb Co-authored-by: Jonathan <[email protected]> --------- Co-authored-by: Jonathan <[email protected]> (cherry picked from commit 611bcfe)
johnBgood
added a commit
that referenced
this pull request
Jan 10, 2025
…) (#3842) * refactor(camunda-client): 1st commit, further investigation needed merging * refactor(camunda-client): fixing the issue, refactor is done * refactor(camunda-client) bring a single camunda version * refactor(camunda-client) bring a single camunda version 5 * refactor(camunda-client) bring a single camunda version 6 * Update connectors/http/rest/README.peb Co-authored-by: Jonathan <[email protected]> --------- Co-authored-by: Jonathan <[email protected]> (cherry picked from commit 611bcfe) Co-authored-by: Mathias Vandaele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
zeebe-clientdependency bycamunda-clientRelated issues
closes #3807
Checklist
no milestonelabel.