Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textract doc handle): add documentation handling for textract #3828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DenovVasil
Copy link
Contributor

@DenovVasil DenovVasil commented Jan 6, 2025

Description

added documentation handling for textract connector
image

Related issues

issue
element template PR
documentation PR

2025-01-16.14-54-45.mov

@DenovVasil DenovVasil self-assigned this Jan 6, 2025
@DenovVasil DenovVasil requested a review from a team as a code owner January 6, 2025 16:21
Oleksiivanov
Oleksiivanov previously approved these changes Jan 7, 2025
Copy link
Contributor

@Oleksiivanov Oleksiivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@DenovVasil DenovVasil force-pushed the 981-add-doc-handling-for-textract branch from 60f9415 to 0b49829 Compare January 7, 2025 10:25
@DenovVasil DenovVasil modified the milestone: 8.7.0-alpha4 Jan 7, 2025
Comment on lines 40 to 43
@TemplateProperty.DropdownPropertyChoice(
value = "UPLOADED",
label = "Uploaded document")
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe "Camunda Document" would be more clear? I would also add a note that could point the user to the relevant documentation page if they don't know what a Camunda document is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines +45 to +47
byte[] docBytes = requestData.document().asByteArray();
document.withBytes(ByteBuffer.wrap(docBytes));
return document;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that we have to load the whole document into memory here, but I don't see an easy streaming-like solution right now. However it could be worth noting in the documentation that if the user wants to handle large files, it's better to upload them to S3 first and use the S3 reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well noted, this is already taken into account, real time execution and is intended for small files, this is described in our documentation.
image

@DenovVasil DenovVasil force-pushed the 981-add-doc-handling-for-textract branch from 0b49829 to a0ff363 Compare January 15, 2025 15:29
Copy link
Contributor

🚀 Deployment Results 🚀

Please find below the results of the latest deployments.

connectors-981-add-doc-han-c8sm

  • Status:
  • URL: 🌐 Link
  • ArgoCD: 🔗 Link
  • Deployment Jobs: 📋 Link

🔧 Troubleshooting 🔧

The 🔗 ArgoCD link can be used to check the state and configuration of all the services deployed as part of the preview environments and get logs.

In case of error, please check 📋 Deployment Jobs and 🔗 ArgoCD to debug, and check our (yet to come) troubleshooting page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants