-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textract doc handle): add documentation handling for textract #3828
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
60f9415
to
0b49829
Compare
@TemplateProperty.DropdownPropertyChoice( | ||
value = "UPLOADED", | ||
label = "Uploaded document") | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe "Camunda Document" would be more clear? I would also add a note that could point the user to the relevant documentation page if they don't know what a Camunda document is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
byte[] docBytes = requestData.document().asByteArray(); | ||
document.withBytes(ByteBuffer.wrap(docBytes)); | ||
return document; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unfortunate that we have to load the whole document into memory here, but I don't see an easy streaming-like solution right now. However it could be worth noting in the documentation that if the user wants to handle large files, it's better to upload them to S3 first and use the S3 reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0b49829
to
a0ff363
Compare
🚀 Deployment Results 🚀Please find below the results of the latest deployments.
|
Description
added documentation handling for textract connector
Related issues
issue
element template PR
documentation PR
2025-01-16.14-54-45.mov