Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication-webhook): change way to retrieve algorithm, more … #3845

Merged
merged 3 commits into from
Jan 13, 2025
Merged

feat(authentication-webhook): change way to retrieve algorithm, more … #3845

merged 3 commits into from
Jan 13, 2025

Conversation

mathias-vandaele
Copy link
Collaborator

…flexible

Description

Fix the issue with intra-id

I tested by deploying an app on azure and everything was working

Related issues

closes ##3794

Checklist

  • PR has a milestone or the no milestone label.

@mathias-vandaele mathias-vandaele requested a review from a team as a code owner January 13, 2025 13:11
@mathias-vandaele mathias-vandaele linked an issue Jan 13, 2025 that may be closed by this pull request
[Webhook Connector] Handle missing ALG key in JWT Auth #3794
Closed
@mathias-vandaele mathias-vandaele self-assigned this Jan 13, 2025
@mathias-vandaele mathias-vandaele added this to the 8.7.0-alpha4 milestone Jan 13, 2025
@mathias-vandaele mathias-vandaele force-pushed the 3794-webhook-connector-handle-missing-alg-key-in-jwt-auth branch from 17947bc to 54ac211 Compare January 13, 2025 13:13
johnBgood
johnBgood previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

connectors/webhook/src/main/java/io/camunda/connector/inbound/authorization/JWTAuthHandler.java Outdated Show resolved Hide resolved
@mathias-vandaele mathias-vandaele added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit dfd774f Jan 13, 2025
11 checks passed
@mathias-vandaele mathias-vandaele deleted the 3794-webhook-connector-handle-missing-alg-key-in-jwt-auth branch January 13, 2025 17:03
@sbuettner
Copy link
Contributor

Successfully created backport PR for release/8.6:

@sbuettner sbuettner mentioned this pull request Jan 13, 2025
Merged
mathias-vandaele added a commit that referenced this pull request Jan 13, 2025
@mathias-vandaele
feat(authentication-webhook): change way to retrieve algorithm, more … (
b5f0936 
#3845)

* feat(authentication-webhook): change way to retrieve algorithm, more flexible

* feat(authentication-webhook): change way to retrieve algorithm, more flexible 2

* feat(authentication-webhook): change way to retrieve algorithm, more flexible 3

(cherry picked from commit dfd774f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

Assignees

@mathias-vandaele mathias-vandaele

Labels
backport release/8.6
Projects
None yet
Milestone
8.7.0-alpha4
Development

Successfully merging this pull request may close these issues.

[Webhook Connector] Handle missing ALG key in JWT Auth
3 participants
@mathias-vandaele @sbuettner @johnBgood