feat(rest-connector): Add flag to get multiple set cookie headers as list #3859
+131
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztefanie
force-pushed
the
3812-add-flag-to-merge-multiple-set-cookie-headers
branch
2 times, most recently
from
2cd2ca1 to
7a423fe
Compare
sbuettner
reviewed
Jan 20, 2025
.../main/java/io/camunda/connector/http/base/client/apache/HttpCommonResultResponseHandler.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
.../main/java/io/camunda/connector/http/base/client/apache/HttpCommonResultResponseHandler.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
.../main/java/io/camunda/connector/http/base/client/apache/HttpCommonResultResponseHandler.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
.../main/java/io/camunda/connector/http/base/client/apache/HttpCommonResultResponseHandler.java
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
...ors/http/http-base/src/main/java/io/camunda/connector/http/base/model/HttpCommonRequest.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Jan 20, 2025
connectors/http/rest/element-templates/http-json-connector.json
Outdated
Show resolved
Hide resolved
sbuettner
previously approved these changes
Jan 20, 2025
johnBgood
reviewed
Jan 20, 2025
.../main/java/io/camunda/connector/http/base/client/apache/HttpCommonResultResponseHandler.java
Outdated
Show resolved
Hide resolved
|
@ztefanie Please also backport this to the 8.6 code base. |
ztefanie
force-pushed
the
3812-add-flag-to-merge-multiple-set-cookie-headers
branch
from
7a423fe to
934162d
Compare
ztefanie
deleted the
3812-add-flag-to-merge-multiple-set-cookie-headers
branch
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.6
git worktree add -d .worktree/backport-3859-to-release/8.6 origin/release/8.6
cd .worktree/backport-3859-to-release/8.6
git switch --create backport-3859-to-release/8.6
git cherry-pick -x 4231107cd22129bfb9343327defdf8aee580cb34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a feature flag to enable getting multiple set cookie headers as a list
if flag is not set to true behavior is not changed
if flag is set to true set cookie headers are merged into a list
other headers are not merged, as set cookie is the only header that is allowed to occure multiple times
PR for documenting this feature is here: connectors: Add hint about merging set cookie headers camunda-docs#4875
Related issues
closes #3812
Checklist
no milestonelabel.