-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors #3880
Merged
johnBgood
merged 8 commits into
main
from
3879-connectors-update-the-inbound-api-to-return-the-results-as-expected-by-console
Feb 5, 2025
Merged
chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors #3880
johnBgood
merged 8 commits into
main
from
3879-connectors-update-the-inbound-api-to-return-the-results-as-expected-by-console
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnectorId for c4-connectors
efcd8ee
to
16f2fbc
Compare
…und contexts and API response
sbuettner
reviewed
Feb 3, 2025
.../src/main/java/io/camunda/connector/runtime/inbound/executable/ActiveExecutableResponse.java
Show resolved
Hide resolved
…turn-the-results-as-expected-by-console
sbuettner
reviewed
Feb 5, 2025
...ain/java/io/camunda/connector/runtime/inbound/controller/InboundConnectorRestController.java
Show resolved
Hide resolved
…lements properties at the element level
sbuettner
reviewed
Feb 5, 2025
...rc/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorReportingContext.java
Show resolved
Hide resolved
sbuettner
reviewed
Feb 5, 2025
...ain/java/io/camunda/connector/runtime/inbound/controller/InboundConnectorRestController.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Feb 5, 2025
connector-sdk/core/src/main/java/io/camunda/connector/api/inbound/ElementTemplateDetails.java
Outdated
Show resolved
Hide resolved
sbuettner
reviewed
Feb 5, 2025
sbuettner
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
sbuettner
approved these changes
Feb 5, 2025
team-connectors-int-automation bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…nnectorId for c4-connectors (#3880) * chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors * feat(inbound-api): add a new activationTimestamp property to the Inbound contexts and API response * other(inbound-api): Add the connector name to the inbound API + add elements properties at the element level * other(inbound-api): Update tests * other(inbound-api): Separate endpoint + small fixes * other(inbound-api): Add SecurityConfiguration tests * other(inbound-api): fix ut (cherry picked from commit 1527365)
Git push to origin failed for release/8.7 with exitcode 1 |
/backport |
Git push to origin failed for release/8.7 with exitcode 1 |
/backport |
team-connectors-int-automation bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…nnectorId for c4-connectors (#3880) * chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors * feat(inbound-api): add a new activationTimestamp property to the Inbound contexts and API response * other(inbound-api): Add the connector name to the inbound API + add elements properties at the element level * other(inbound-api): Update tests * other(inbound-api): Separate endpoint + small fixes * other(inbound-api): Add SecurityConfiguration tests * other(inbound-api): fix ut (cherry picked from commit 1527365)
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
data
will now return the full connector configuration, I kept the path key for the Webhook connector for compatibility reasons.Complete description in #3879
Related issues
closes #3879
Checklist
no milestone
label.