Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors #3880

Conversation

johnBgood
Copy link
Collaborator

@johnBgood johnBgood commented Jan 27, 2025

Description

  • The /inbound endpoint can now return connectors instances grouped by their ConnectorId.
  • data will now return the full connector configuration, I kept the path key for the Webhook connector for compatibility reasons.

Complete description in #3879

Related issues

closes #3879

Checklist

  • PR has a milestone or the no milestone label.

@johnBgood johnBgood self-assigned this Jan 27, 2025
@johnBgood johnBgood requested a review from a team as a code owner January 27, 2025 10:05
@johnBgood johnBgood added this to the 8.7.0-alpha4 milestone Jan 27, 2025
@johnBgood johnBgood changed the title feat(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors Jan 27, 2025
@johnBgood johnBgood force-pushed the 3879-connectors-update-the-inbound-api-to-return-the-results-as-expected-by-console branch from efcd8ee to 16f2fbc Compare January 27, 2025 10:08
@johnBgood johnBgood requested a review from sbuettner February 5, 2025 14:46
sbuettner
sbuettner previously approved these changes Feb 5, 2025
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@johnBgood johnBgood added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 1527365 Feb 5, 2025
19 checks passed
@johnBgood johnBgood deleted the 3879-connectors-update-the-inbound-api-to-return-the-results-as-expected-by-console branch February 5, 2025 16:17
team-connectors-int-automation bot pushed a commit that referenced this pull request Feb 5, 2025
…nnectorId for c4-connectors (#3880)

* chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors

* feat(inbound-api): add a new activationTimestamp property to the Inbound contexts and API response

* other(inbound-api): Add the connector name to the inbound API + add elements properties at the element level

* other(inbound-api): Update tests

* other(inbound-api): Separate endpoint + small fixes

* other(inbound-api): Add SecurityConfiguration tests

* other(inbound-api): fix ut

(cherry picked from commit 1527365)
@team-connectors-int-automation

Git push to origin failed for release/8.7 with exitcode 1

@sbuettner
Copy link
Contributor

/backport

@team-connectors-int-automation

Git push to origin failed for release/8.7 with exitcode 1

@sbuettner
Copy link
Contributor

/backport

team-connectors-int-automation bot pushed a commit that referenced this pull request Feb 5, 2025
…nnectorId for c4-connectors (#3880)

* chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors

* feat(inbound-api): add a new activationTimestamp property to the Inbound contexts and API response

* other(inbound-api): Add the connector name to the inbound API + add elements properties at the element level

* other(inbound-api): Update tests

* other(inbound-api): Separate endpoint + small fixes

* other(inbound-api): Add SecurityConfiguration tests

* other(inbound-api): fix ut

(cherry picked from commit 1527365)
@team-connectors-int-automation

johnBgood pushed a commit that referenced this pull request Feb 5, 2025
…nnectorId for c4-connectors (#3880) (#3926)

* chore(inbound-api): add a parameter to group inbound connectors by ConnectorId for c4-connectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Connectors] Update the Inbound API to return the results as expected by Console
2 participants