refactor(http-json): abstract http json connector for extensibility #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlukas
changed the title
jonathanlukas
changed the title
johnBgood
approved these changes
Jan 28, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
connectors/http/rest/src/main/java/io/camunda/connector/http/rest/HttpJsonFunction.java
Dismissed
Show dismissed
Hide dismissed
|
@johnBgood there are webhook tests failing because of credentials... is this a known issue? |
it was not, I don't have the time to look into it right now it might have to wait until the end of the Kick-off |
auto-merge was automatically disabled
January 30, 2025 11:21
Pull request was closed
|
@johnBgood I closed this pr because I found another way of reaching my goal :) thank you for having a look yesterday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modularizes the http json connector so that it could be extended if required.
Related issues
closes #
Checklist
no milestonelabel.