-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up schema and add C8 JSON Schema #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `json-schema-ref-parser` to bundle schema chunks into a final one.
Move base element template definitions into a `defs` sub folder
pinussilvestrus
force-pushed
the
561-c8-schema
branch
from
February 8, 2022 13:51
7a0cbe4
to
90ef334
Compare
Also, find some more reasoning about this initiative in my lightning talk. |
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Feb 8, 2022
pinussilvestrus
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
February 8, 2022 14:31
6 tasks
Note: this PR still includes the term |
This was referenced Feb 14, 2022
Merged
philippfromme
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean structure! Great job, @pinussilvestrus! 👏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/bpmn-js-properties-panel#561
This demonstrates how to split up the existing JSON Schema into smaller chunks (
src/defs
) and generate it back to the exporting schema asbuild
step.Furthermore, it's adding support for the new C8 templates bindings on top:
zeebe:taskDefinition:type
zeebe:taskHeader
(binding.key
is required)zeebe:input
(binding.name
is required)zeebe:output
(binding.source
is required)optional
for inputs and outputsoptional
forconstraints.notEmpty = true
Things to clarify in kick off (can still be changed later)
resources/*.json
)? schema / platform / cloud vs. C7 / C8?