Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up schema and add C8 JSON Schema #41

Merged
merged 6 commits into from
Feb 14, 2022
Merged

Split up schema and add C8 JSON Schema #41

merged 6 commits into from
Feb 14, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Feb 7, 2022

Related to bpmn-io/bpmn-js-properties-panel#561

This demonstrates how to split up the existing JSON Schema into smaller chunks (src/defs) and generate it back to the exporting schema as build step.

Furthermore, it's adding support for the new C8 templates bindings on top:

  • zeebe:taskDefinition:type
  • zeebe:taskHeader (binding.key is required)
  • zeebe:input (binding.name is required)
  • zeebe:output (binding.source is required)
  • optional for inputs and outputs
  • do not allow optional for constraints.notEmpty = true

Things to clarify in kick off (can still be changed later)

  • how to name exports (resources/*.json)? schema / platform / cloud vs. C7 / C8?
  • multi-package? use the same version for both?

Niklas Kiefer and others added 4 commits February 5, 2022 18:46
Uses `json-schema-ref-parser` to bundle schema chunks into a final one.
Move base element template definitions into a `defs` sub folder
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 7, 2022
@pinussilvestrus pinussilvestrus self-assigned this Feb 7, 2022
@pinussilvestrus
Copy link
Contributor Author

Also, find some more reasoning about this initiative in my lightning talk.

@pinussilvestrus pinussilvestrus marked this pull request as ready for review February 8, 2022 14:31
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 8, 2022
@pinussilvestrus pinussilvestrus requested review from a team, philippfromme and marstamm and removed request for a team February 8, 2022 14:31
@pinussilvestrus
Copy link
Contributor Author

Note: this PR still includes the term cloud. We just decided we will use zeebe as the namespace. I will handle/rename this separately in a later PR.

This was referenced Feb 14, 2022
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean structure! Great job, @pinussilvestrus! 👏🏻

@merge-me merge-me bot merged commit 085d043 into master Feb 14, 2022
@merge-me merge-me bot deleted the 561-c8-schema branch February 14, 2022 13:33
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants