Feature/no gradle #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiicamundi
force-pushed
the
feature/no-gradle
branch
from
eba0849 to
ee7f6d3
Compare
maxdanilov
requested changes
Mar 22, 2024
maxdanilov
requested changes
Mar 25, 2024
|
Thanks for the review @maxdanilov, those changes has just been published in https://github.com/camunda/keycloak/releases/tag/2024-03-26-001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we maintained a gradle.build file with dependency versions. These dependencies could be updated regularly.
Since version 24 of Keycloak, the Keycloak team has been testing the integration of Aurora DB with a version of the AWS wrapper referenced here: keycloak/keycloak@eadd1c4
To align with what is tested by Keycloak and thus avoid compatibility issues, this PR makes a modification to the dependency construction.
It retrieves the pom.xml of the Keycloak version, extracts the referenced version of the AWS wrapper, and then downloads the pom.xml of the latter and installs all transitive dependencies with Maven (this is done in the builder step).
A utility script retrieves the version of the wrapper to download from the version of keycloak.
This PR also includes the removal of the launcher workaround since bitnami/containers#63945 has been merged.
fixes #43