address review comments

charmcraft.yaml

@@ -103,9 +103,9 @@ config:
     ##### Secrets config #####
     secret-persistence:
       description: |
-        Defines the Secret Persistence type. Defaults to NO_OP.
+        Defines the Secret Persistence type.
 
-        Acceptable values are: "GOOGLE_SECRET_MANAGER", "AWS_SECRET_MANAGER", "TESTING_CONFIG_DB_TABLE", "VAULT"
+        If set, acceptable values are: "GOOGLE_SECRET_MANAGER", "AWS_SECRET_MANAGER", "TESTING_CONFIG_DB_TABLE", "VAULT"
       type: string
 
     secret-store-gcp-project-id:
@@ -193,6 +193,7 @@ config:
 
     sync-job-max-timeout-days:
       description: Number of days a sync job will execute for before timing out.
+      default: 3
       type: int
 
     job-main-container-cpu-request:
@@ -214,14 +215,17 @@ config:
     ##### Connections config #####
     max-fields-per-connections:
       description: Maximum number of fields able to be selected for a single connection.
+      default: 20000
       type: int
 
     max-days-of-only-failed-jobs-before-connection-disable:
       description: Number of consecuative days of only failed jobs before the connection is disabled.
+      default: 14
       type: int
 
     max-failed-jobs-in-a-row-before-connection-disable:
       description: Number of consecuative failed jobs before the connection is disabled.
+      default: 20
       type: int
 
     ##### Worker config #####

tests/unit/test_charm.py

@@ -361,7 +361,10 @@ def create_plan(container_name, storage_type):
                     "KEYCLOAK_INTERNAL_HOST": "localhost",
                     "LOG_LEVEL": "INFO",
                     "MAX_CHECK_WORKERS": 5,
+                    "MAX_DAYS_OF_ONLY_FAILED_JOBS_BEFORE_CONNECTION_DISABLE": 14,
                     "MAX_DISCOVER_WORKERS": 5,
+                    "MAX_FAILED_JOBS_IN_A_ROW_BEFORE_CONNECTION_DISABLE": 20,
+                    "MAX_FIELDS_PER_CONNECTION": 20000,
                     "MAX_SPEC_WORKERS": 5,
                     "MAX_SYNC_WORKERS": 5,
                     "RUNNING_TTL_MINUTES": 240,
@@ -373,6 +376,7 @@ def create_plan(container_name, storage_type):
                     "STORAGE_BUCKET_WORKLOAD_OUTPUT": "airbyte-state-storage",
                     "STORAGE_TYPE": storage_type,
                     "SUCCEEDED_TTL_MINUTES": 30,
+                    "SYNC_JOB_MAX_TIMEOUT_DAYS": 3,
                     "SYNC_JOB_RETRIES_COMPLETE_FAILURES_BACKOFF_BASE": 3,
                     "SYNC_JOB_RETRIES_COMPLETE_FAILURES_BACKOFF_MAX_INTERVAL_S": 1800,
                     "SYNC_JOB_RETRIES_COMPLETE_FAILURES_BACKOFF_MIN_INTERVAL_S": 10,