Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests, linting and tests CI/CD #8

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Add unit tests, linting and tests CI/CD #8

merged 2 commits into from
Jun 11, 2024

Conversation

kelkawi-a
Copy link
Collaborator

This PR:

  • Adds unit tests
  • Conforms to linter rules
  • Adds an operator-workflows Github action for running unit tests and other checks on merges with the main branch.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 31 files.

Valid Invalid Ignored Fixed
19 1 11 0
Click to see the invalid file list
  • src/scripts/pod-sweeper.sh
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

tox.ini Show resolved Hide resolved
Copy link

@onurmus onurmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelkawi-a kelkawi-a merged commit ab3c4ce into main Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants