Add integration test #9
Conversation
kelkawi-a
force-pushed
the
integration-tests
branch
from
2b12541 to
e94b94f
Compare
kelkawi-a
requested review from
gtato,
onurmus,
mertalpt,
kian99,
AmberCharitos and
maabujayyab
| # set a predictable model name so it can be consumed by charm-logdump-action | ||
| run: tox -e integration -- --model testing | ||
| - name: Dump logs | ||
| uses: canonical/charm-logdump-action@main |
There was a problem hiding this comment.
This action is now available on the v2.6.0 release.
As a side note for the future, I recommend setting up renovatebot to get your actions and deps pinned to exact commits or versions and have renovate update them automatically.
This next bit is probably worth a CSShare, but the observability charms and identity charms have some nice CI setup to automatically merge renovatebot PRs that pass unit/integration tests.
I've adapted Hydra's renovate config for example in JIMM. Then you can setup some cool automation to get those PRs merged without user intervention.
There was a problem hiding this comment.
To accommodate for the new integration test of running an Airbyte sync, I actually had to switch to the integration tests workflow offered by the IS Devops team to be able to use larger self-hosted Github runners.
Thanks for the heads up on the CI, will look into that!
kelkawi-a
force-pushed
the
integration-tests
branch
5 times, most recently
from
3f02245 to
c9d2c7d
Compare
| ) | ||
|
|
||
| await perform_temporal_integrations(ops_test) | ||
| await create_default_namespace(ops_test) |
There was a problem hiding this comment.
do you have to create the default namespace manually, isn't the relation between temporal and airbyte going to create a namespace?
There was a problem hiding this comment.
There's currently no relation between Temporal and Airbyte charms, so this step needs to be done manually.
tests/integration/test_charm.py
Outdated
| break | ||
|
|
||
| if status == "succeeded": | ||
| logger.info(f"attempt {i}: job successful!") |
There was a problem hiding this comment.
is this storing pikachu in the db or smth? 😄
kelkawi-a
force-pushed
the
integration-tests
branch
13 times, most recently
from
2d93185 to
4c0fdff
Compare
kelkawi-a
force-pushed
the
integration-tests
branch
5 times, most recently
from
f758c8e to
96b50cf
Compare
kelkawi-a
force-pushed
the
integration-tests
branch
from
96b50cf to
5c325c5
Compare
This PR adds an integration test to ensure the application can be deployed successfully and a Github action for running integration tests on merging with the
mainbranch.