Fix lp copy packages arbitrary lookback (infra) #1067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
lp_copy_packages.py
script failed to update our stable PPA because it assumed that any package that had to be copied over was less than 4 weeks old.This is false for two reasons:
Superseeded
(namely, we have a more current version in the PPA of that same package)Resolved issues
Last stable release failed to update stable channel, see log: https://github.com/canonical/checkbox/actions/runs/7987143879/job/21809020771
(No copying over message -> no package copied over)
Documentation
This PR adds documentation for what the function does and also adds a note about the more "counterintuitive" side of it (the fact that non-superseeded packages may still be non-copy-wrothy)
Tests
This updates the test with the new two cases at hand