Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover loopback genio test (New) #1081

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Cover loopback genio test (New) #1081

merged 3 commits into from
Mar 18, 2024

Conversation

fernando79513
Copy link
Collaborator

@fernando79513 fernando79513 commented Mar 18, 2024 •
edited
Loading

Description

After the inclusion of genio tests on the contrib area of checkbox, we have to add unit-tests to ensure the coverage requirements are satisfied. We have included unit-tests for the gpio_loopback_test.py script.

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-1297 (follow-up)

Documentation

There are no changes to the documentation

Tests

To run the unittests:

cd ~/checkbox/contrib/genio
pytest

Coverage Report

Module statements missing excluded branches partial coverage
bin/cpu_idle.py 142 1 0 50 1 99%
bin/boot_partition.py 91 1 0 28 1 98%
bin/gpio_loopback_test.py 93 1 0 26 1 98%
bin/pmic_regulator.py 49 1 0 16 1 97%
bin/spidev_test.py 37 1 0 12 1 96%
bin/dvfs_gpu_check_governors.py 25 1 0 12 1 95%
bin/linux_ccf.py 45 1 0 18 2 95%
bin/serialcheck.py 34 1 0 8 1 95%
bin/brightness_test.py 92 92 0 30 0 0%
Total 608 100 0 200 9 83%

@fernando79513 fernando79513 changed the title Cover loopback genio test Cover loopback genio test (New) Mar 18, 2024
kissiel
kissiel approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@kissiel kissiel merged commit d522d71 into main Mar 18, 2024
4 checks passed
@kissiel kissiel deleted the cover-loopback-genio-test branch March 18, 2024 16:13
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
@fernando79513 @binli
Cover loopback genio test (New) (canonical#1081)
73b75ac 
* Removed SystemExit on passing test and removed typo

* Add unit tests for GPIO loopback functionality

* mock the GPIOSysFsController object instead of patching all the methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kissiel kissiel kissiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernando79513 @kissiel